Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files Errors
70 1082

Files

Files Errors
org/codehaus/nanning/AspectException.java 9
org/codehaus/nanning/AspectFactory.java 5
org/codehaus/nanning/AspectInstance.java 97
org/codehaus/nanning/Aspects.java 36
org/codehaus/nanning/ConstructionInterceptor.java 3
org/codehaus/nanning/ConstructionInvocation.java 5
org/codehaus/nanning/Interceptor.java 1
org/codehaus/nanning/Invocation.java 9
org/codehaus/nanning/MethodInterceptor.java 6
org/codehaus/nanning/Mixin.java 120
org/codehaus/nanning/attribute/AbstractAttributesTest.java 17
org/codehaus/nanning/attribute/AttributeException.java 10
org/codehaus/nanning/attribute/Attributes.java 1
org/codehaus/nanning/attribute/Attributes.java 83
org/codehaus/nanning/attribute/AttributesBuilder.java 1
org/codehaus/nanning/attribute/AttributesBuilder.java 44
org/codehaus/nanning/attribute/AttributesCompiler.java 1
org/codehaus/nanning/attribute/AttributesCompiler.java 38
org/codehaus/nanning/attribute/AttributesLoader.java 3
org/codehaus/nanning/attribute/ClassAttributes.java 51
org/codehaus/nanning/attribute/ClassPropertiesHelper.java 94
org/codehaus/nanning/attribute/PropertyFileAttributeLoader.java 16
org/codehaus/nanning/attribute/package.html 1
org/codehaus/nanning/config/AbstractAspect.java 6
org/codehaus/nanning/config/Aspect.java 4
org/codehaus/nanning/config/AspectSystem.java 27
org/codehaus/nanning/config/AttributePointcut.java 14
org/codehaus/nanning/config/ClassAspect.java 16
org/codehaus/nanning/config/FindTargetMixinAspect.java 25
org/codehaus/nanning/config/InterceptorAspect.java 46
org/codehaus/nanning/config/MixinAspect.java 32
org/codehaus/nanning/config/P.java 149
org/codehaus/nanning/config/Pointcut.java 38
org/codehaus/nanning/config/package.html 1
org/codehaus/nanning/package.html 1
org/codehaus/nanning/samples/StopWatch.java 29
org/codehaus/nanning/samples/package.html 1
org/codehaus/nanning/test/TestUtils.java 5
org/codehaus/nanning/test/package.html 1
org/codehaus/nanning/xml/AspectSystemParser.java 35
org/codehaus/nanning/xml/package.html 1

org/codehaus/nanning/AspectException.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 20
Missing a Javadoc comment. 24
Parameter message should be final. 24
Missing a Javadoc comment. 28
Parameter e should be final. 28
Missing a Javadoc comment. 32
Parameter message should be final. 32
Parameter cause should be final. 32

org/codehaus/nanning/AspectFactory.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 10
Line has trailing spaces. 11
Missing a Javadoc comment. 12
Missing a Javadoc comment. 14

org/codehaus/nanning/AspectInstance.java

Error Line
Line does not match expected header line of ' $Id: LICENSE.txt,v 1.1 2003/07/17 16:32:02 tirsen Exp $'. 2
Missing a Javadoc comment. 45
Missing a Javadoc comment. 47
Missing a Javadoc comment. 48
Missing a Javadoc comment. 49
Missing a Javadoc comment. 51
Missing a Javadoc comment. 52
Missing a Javadoc comment. 53
Missing a Javadoc comment. 55
Missing a Javadoc comment. 58
Parameter aspectFactory should be final. 58
'aspectFactory' hides a field. 58
Parameter classIdentifier should be final. 58
'classIdentifier' hides a field. 58
Missing a Javadoc comment. 63
Parameter classIdentifier should be final. 63
'classIdentifier' hides a field. 63
Missing a Javadoc comment. 67
Missing a Javadoc comment. 79
Parameter proxy should be final. 79
'proxy' hides a field. 79
Parameter method should be final. 79
Parameter args should be final. 79
Line is longer than 80 characters. 95
Missing a Javadoc comment. 108
Parameter interfaceClass should be final. 108
Missing a Javadoc comment. 113
Parameter interfaceClass should be final. 113
Expected an @return tag. 123
Parameter interfaceClass should be final. 123
Expected @param tag for 'interfaceClass'. 123
Line is longer than 80 characters. 125
Missing a Javadoc comment. 129
Parameter interfaceClass should be final. 129
Missing a Javadoc comment. 133
Parameter interfaceClass should be final. 133
Parameter target should be final. 133
Missing a Javadoc comment. 138
Line is longer than 80 characters. 146
Missing a Javadoc comment. 146
Parameter objectInputStream should be final. 146
Line is longer than 80 characters. 149
Missing a Javadoc comment. 154
Parameter mixin should be final. 162
Expected @param tag for 'mixin'. 162
Missing a Javadoc comment. 169
Parameter mixinsList should be final. 169
'mixinsList' hides a field. 169
Line is longer than 80 characters. 174
Line is longer than 80 characters. 179
Line is longer than 80 characters. 184
Parameter interfaceClass should be final. 184
Expected @param tag for 'interfaceClass'. 184
Parameter mixinInstance should be final. 184
Expected @param tag for 'mixinInstance'. 184
Line is longer than 80 characters. 200
Expected an @return tag. 204
Line is longer than 80 characters. 210
Line is longer than 80 characters. 213
Line is longer than 80 characters. 214
Line is longer than 80 characters. 222
Expected an @return tag. 227
Parameter method should be final. 227
Expected @param tag for 'method'. 227
Line is longer than 80 characters. 228
Line is longer than 80 characters. 232
Expected an @return tag. 235
Line is longer than 80 characters. 239
Missing a Javadoc comment. 239
Missing a Javadoc comment. 240
Missing a Javadoc comment. 241
Missing a Javadoc comment. 243
Parameter proxy should be final. 243
'proxy' hides a field. 243
Parameter interfaceClass should be final. 243
'interfaceClass' hides a field. 243
Missing a Javadoc comment. 248
Missing a Javadoc comment. 252
Missing a Javadoc comment. 256
Parameter target should be final. 256
Missing a Javadoc comment. 261
Line is longer than 80 characters. 265
Missing a Javadoc comment. 272
Parameter proxy should be final. 272
'proxy' hides a field. 272
Line is longer than 80 characters. 278
Line is longer than 80 characters. 279
Line is longer than 80 characters. 280
Missing a Javadoc comment. 291
'+' should be on a new line. 295
Expected an @return tag. 303
Line is longer than 80 characters. 308
Line is longer than 80 characters. 310
Parameter constructionInterceptor should be final. 310
Expected @param tag for 'constructionInterceptor'. 310
Missing a Javadoc comment. 317
Parameter interceptor should be final. 317

org/codehaus/nanning/Aspects.java

Error Line
Line does not match expected header line of ' $Id: LICENSE.txt,v 1.1 2003/07/17 16:32:02 tirsen Exp $'. 2
Utility classes should not have a public or default constructor. 21
Line is longer than 80 characters. 22
Missing a Javadoc comment. 22
Missing a Javadoc comment. 23
Parameter proxy should be final. 31
Expected @param tag for 'proxy'. 31
Parameter proxy should be final. 42
Expected @param tag for 'proxy'. 42
Parameter interfaceClass should be final. 42
Expected @param tag for 'interfaceClass'. 42
Expected an @return tag. 51
Parameter proxy should be final. 51
Expected @param tag for 'proxy'. 51
Line is longer than 80 characters. 61
Parameter proxy should be final. 61
Expected @param tag for 'proxy'. 61
Parameter interfaceClass should be final. 61
Expected @param tag for 'interfaceClass'. 61
Parameter target should be final. 61
Expected @param tag for 'target'. 61
Missing a Javadoc comment. 65
Parameter o should be final. 65
Avoid inline conditionals. 66
Missing a Javadoc comment. 69
Parameter object should be final. 69
Line is longer than 80 characters. 70
Avoid inline conditionals. 70
Missing a Javadoc comment. 73
Missing a Javadoc comment. 81
Parameter factory should be final. 81
Parameter proxyClass should be final. 91
Line is longer than 80 characters. 107
Expected an @return tag. 111
Missing a Javadoc comment. 115
Parameter proxy should be final. 115

org/codehaus/nanning/ConstructionInterceptor.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 10
Missing a Javadoc comment. 11

org/codehaus/nanning/ConstructionInvocation.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 10
Missing a Javadoc comment. 11
Missing a Javadoc comment. 13
Missing a Javadoc comment. 15

org/codehaus/nanning/Interceptor.java

Error Line
Missing a header - not enough lines in file. 1

org/codehaus/nanning/Invocation.java

Error Line
Line does not match expected header line of ' $Id: LICENSE.txt,v 1.1 2003/07/17 16:32:02 tirsen Exp $'. 2
Line is longer than 80 characters. 13
Line is longer than 80 characters. 24
Expected @param tag for 'o'. 41
Line is longer than 80 characters. 44
Missing a Javadoc comment. 86
Missing a Javadoc comment. 88
Missing a Javadoc comment. 90
Missing a Javadoc comment. 92

org/codehaus/nanning/MethodInterceptor.java

Error Line
Missing a header - not enough lines in file. 1
Line is longer than 80 characters. 13
Line is longer than 80 characters. 22
Line is longer than 80 characters. 25
Line is longer than 80 characters. 26
Expected @param tag for 'invocation'. 28

org/codehaus/nanning/Mixin.java

Error Line
Line does not match expected header line of ' $Id: LICENSE.txt,v 1.1 2003/07/17 16:32:02 tirsen Exp $'. 2
Using the '.*' form of import should be avoided - java.util.*. 12
Line is longer than 80 characters. 15
Line is longer than 80 characters. 16
Missing a Javadoc comment. 43
Missing a Javadoc comment. 45
Missing a Javadoc comment. 46
Missing a Javadoc comment. 48
Missing a Javadoc comment. 50
Missing a Javadoc comment. 53
Parameter interfaceClass should be final. 53
'interfaceClass' hides a field. 53
Parameter target should be final. 53
'target' hides a field. 53
Method 'setInterfaceClass' is not designed for extension - needs to be abstract, final or empty. 58
Missing a Javadoc comment. 58
Parameter interfaceClass should be final. 58
'interfaceClass' hides a field. 58
Method 'setTarget' is not designed for extension - needs to be abstract, final or empty. 62
Missing a Javadoc comment. 62
Parameter target should be final. 62
'target' hides a field. 62
Method 'getInterfaceClass' is not designed for extension - needs to be abstract, final or empty. 67
Missing a Javadoc comment. 67
Method 'getAllInterceptors' is not designed for extension - needs to be abstract, final or empty. 71
Missing a Javadoc comment. 71
Line is longer than 80 characters. 74
Line is longer than 80 characters. 76
Line is longer than 80 characters. 77
Method 'getTarget' is not designed for extension - needs to be abstract, final or empty. 85
Missing a Javadoc comment. 85
Method 'getInterceptorsForMethod' is not designed for extension - needs to be abstract, final or empty. 89
Missing a Javadoc comment. 89
Parameter method should be final. 89
Missing a Javadoc comment. 101
Missing a Javadoc comment. 102
Variable 'proxy' must be private and have accessor methods. 102
Missing a Javadoc comment. 103
Variable 'method' must be private and have accessor methods. 103
Missing a Javadoc comment. 104
Variable 'args' must be private and have accessor methods. 104
Missing a Javadoc comment. 105
Variable 'interceptors' must be private and have accessor methods. 105
Missing a Javadoc comment. 107
Parameter proxy should be final. 107
'proxy' hides a field. 107
Parameter method should be final. 107
'method' hides a field. 107
Parameter args should be final. 107
'args' hides a field. 107
Method 'invokeNext' is not designed for extension - needs to be abstract, final or empty. 114
Missing a Javadoc comment. 114
Line is longer than 80 characters. 127
Missing a Javadoc comment. 127
Parameter e should be final. 127
Method 'getInterceptor' is not designed for extension - needs to be abstract, final or empty. 138
Missing a Javadoc comment. 138
Parameter index should be final. 138
Method 'getTargetInterface' is not designed for extension - needs to be abstract, final or empty. 142
Missing a Javadoc comment. 142
Method 'getAspectInstance' is not designed for extension - needs to be abstract, final or empty. 146
Missing a Javadoc comment. 146
Method 'getArgumentCount' is not designed for extension - needs to be abstract, final or empty. 150
Missing a Javadoc comment. 150
Method 'getArgument' is not designed for extension - needs to be abstract, final or empty. 154
Missing a Javadoc comment. 154
Parameter arg should be final. 154
Method 'getTarget' is not designed for extension - needs to be abstract, final or empty. 158
Missing a Javadoc comment. 158
Method 'setTarget' is not designed for extension - needs to be abstract, final or empty. 162
Missing a Javadoc comment. 162
Parameter target should be final. 162
'target' hides a field. 162
Method 'getProxy' is not designed for extension - needs to be abstract, final or empty. 166
Missing a Javadoc comment. 166
Method 'getCurrentIndex' is not designed for extension - needs to be abstract, final or empty. 170
Missing a Javadoc comment. 170
Method 'getfInterceptorCount' is not designed for extension - needs to be abstract, final or empty. 174
Missing a Javadoc comment. 174
Method 'getMethod' is not designed for extension - needs to be abstract, final or empty. 178
Missing a Javadoc comment. 178
Method 'getArgs' is not designed for extension - needs to be abstract, final or empty. 182
Missing a Javadoc comment. 182
Method 'getMainClass' is not designed for extension - needs to be abstract, final or empty. 187
Missing a Javadoc comment. 187
Method 'invokeMethod' is not designed for extension - needs to be abstract, final or empty. 191
Missing a Javadoc comment. 191
Parameter proxy should be final. 191
Parameter method should be final. 191
Parameter args should be final. 191
Method 'isMainMixin' is not designed for extension - needs to be abstract, final or empty. 198
Missing a Javadoc comment. 198
Method 'addInterceptor' is not designed for extension - needs to be abstract, final or empty. 206
Parameter interceptor should be final. 206
Expected @param tag for 'interceptor'. 206
Method 'equals' is not designed for extension - needs to be abstract, final or empty. 214
Missing a Javadoc comment. 214
Parameter o should be final. 214
'if' construct must use '{}'s. 215
'if' construct must use '{}'s. 216
'if' construct must use '{}'s. 220
Line is longer than 80 characters. 220
Avoid inline conditionals. 220
'if' construct must use '{}'s. 221
Line is longer than 80 characters. 221
Avoid inline conditionals. 221
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 226
Missing a Javadoc comment. 226
Avoid inline conditionals. 228
'29' is a magic number. 229
Avoid inline conditionals. 229
Method 'addInterceptor' is not designed for extension - needs to be abstract, final or empty. 238
Parameter method should be final. 238
Expected @param tag for 'method'. 238
Parameter interceptor should be final. 238
Expected @param tag for 'interceptor'. 238
Method 'getAllMethods' is not designed for extension - needs to be abstract, final or empty. 242
Missing a Javadoc comment. 242
Method 'toString' is not designed for extension - needs to be abstract, final or empty. 246
Missing a Javadoc comment. 246

org/codehaus/nanning/attribute/AbstractAttributesTest.java

Error Line
Line does not match expected header line of '/*'. 1
Line is longer than 80 characters. 9
Line is longer than 80 characters. 10
Missing a Javadoc comment. 15
Missing a Javadoc comment. 16
Method 'setUp' is not designed for extension - needs to be abstract, final or empty. 18
Missing a Javadoc comment. 18
Missing a Javadoc comment. 23
Missing a Javadoc comment. 39
Parameter baseDir should be final. 39
Line is longer than 80 characters. 42
Line is longer than 80 characters. 46
Line is longer than 80 characters. 47
Missing a Javadoc comment. 52
Parameter source should be final. 52
Missing a Javadoc comment. 61
Parameter path should be final. 61

org/codehaus/nanning/attribute/AttributeException.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 3
Missing a Javadoc comment. 4
Parameter message should be final. 4
Missing a Javadoc comment. 9
Missing a Javadoc comment. 12
Parameter message should be final. 12
Parameter cause should be final. 12
Missing a Javadoc comment. 16
Parameter cause should be final. 16

org/codehaus/nanning/attribute/Attributes.java

Error Line
File does not end with a newline. 0

org/codehaus/nanning/attribute/Attributes.java

Error Line
Line does not match expected header line of ' $Id: LICENSE.txt,v 1.1 2003/07/17 16:32:02 tirsen Exp $'. 2
Using the '.*' form of import should be avoided - java.util.*. 13
Comment matches to-do format 'TODO:'. 20
Line is longer than 80 characters. 21
Line is longer than 80 characters. 22
Utility classes should not have a public or default constructor. 30
Missing a Javadoc comment. 31
Missing a Javadoc comment. 32
Missing a Javadoc comment. 34
Parameter klass should be final. 34
Parameter attribute should be final. 34
Missing a Javadoc comment. 38
Parameter method should be final. 38
Parameter attribute should be final. 38
Line is longer than 80 characters. 39
Missing a Javadoc comment. 42
Parameter field should be final. 42
Parameter attribute should be final. 42
Line is longer than 80 characters. 43
Missing a Javadoc comment. 46
Parameter searchPath should be final. 46
Missing a Javadoc comment. 50
Parameter searchPath should be final. 50
Missing a Javadoc comment. 54
Parameter klass should be final. 54
Parameter attribute should be final. 54
Missing a Javadoc comment. 58
Parameter method should be final. 58
Parameter attribute should be final. 58
Line is longer than 80 characters. 62
Missing a Javadoc comment. 62
Parameter aClass should be final. 62
Parameter method should be final. 62
Parameter attribute should be final. 62
Missing a Javadoc comment. 66
Parameter field should be final. 66
Parameter attribute should be final. 66
Line is longer than 80 characters. 70
Missing a Javadoc comment. 70
Parameter aClass should be final. 70
Parameter field should be final. 70
Parameter attribute should be final. 70
Missing a Javadoc comment. 74
Parameter field should be final. 74
Parameter attribute should be final. 74
Line is longer than 80 characters. 75
Line is longer than 80 characters. 78
Missing a Javadoc comment. 78
Parameter aClass should be final.